Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when ignoreNonObjectArgs is unnecessary. #414

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Error when ignoreNonObjectArgs is unnecessary. #414

wants to merge 1 commit into from

Conversation

dmaclach
Copy link
Contributor

@dmaclach dmaclach commented May 7, 2020

This encourages proper use of the APIS and keeps the testing code cleaner and easier to
read.

I would like to probably actually implement this as a warning that could be turned into an error (see #413)

@dmaclach dmaclach mentioned this pull request May 7, 2020
Open
@erikdoe
Copy link
Owner

erikdoe commented May 11, 2020

Agree on warning by default. Making this an error will cause a lot of unexpected problems for existing test suites.

@dmaclach
Copy link
Contributor Author

dmaclach commented Jun 6, 2020

I will happily refactor this on top of #424 if that gets in.

@erikdoe erikdoe added this to the OCMock 3.9 (or later) milestone Jun 22, 2020
@dmaclach dmaclach mentioned this pull request Jul 13, 2020
Merged
@dmaclach
Error when ignoreNonObjectArgs is unnecessary.
7fa24af 
This encourages proper use of the APIS and keeps the testing code cleaner and easier to
read.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
OCMock 3.10 (or later)
Development

Successfully merging this pull request may close these issues.
2 participants
@dmaclach @erikdoe